Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning
From: Krzysztof Kozlowski
Date: Mon Aug 10 2020 - 10:15:33 EST
On Mon, Aug 10, 2020 at 08:30:21AM +0530, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following false-positive error:
> "IRQ index 1 not found" on newer SoC's.
>
> This patch adds the condition to check for Tx interrupt
> only for the those SoC's which have 2 interrupt lines.
>
> Signed-off-by: Tamseel Shams <m.shams@xxxxxxxxxxx>
> ---
> Commit message is changed.
>
> Added RFT, for older platform.
>
> Addressed Krzysztof's review comments [1]
> [1] -> https://lkml.org/lkml/2020/7/21/150
>
> drivers/tty/serial/samsung_tty.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof