Re: [PATCH] kernel: update callers of task_work_add() to use TWA_RESUME

From: Jens Axboe
Date: Mon Aug 10 2020 - 10:37:59 EST


On 8/10/20 5:44 AM, peterz@xxxxxxxxxxxxx wrote:
> On Sat, Aug 08, 2020 at 03:43:50PM -0600, Jens Axboe wrote:
>> Any pre-existing caller of this function uses 'true' to signal to use
>> notifications or not, but we now also have signaled notifications.
>> Update existing callers that specify 'true' for notify to use the
>> updated TWA_RESUME instead.
>>
>> This was noted in the original commit as well:
>>
>> e91b48162332 ("task_work: teach task_work_add() to do signal_wake_up()")
>>
>> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>>
>
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>
> How do you want to route this?

I don't really care, as I have no dependencies on it. Feel free to queue
it up! It's just sitting at the top of my io_uring branch right now,
but that's because I had to stuff it somewhere. Easy to pop off the top.

--
Jens Axboe