Re: [PATCH] regulator: fix pointer table overallocation
From: Michał Mirosław
Date: Mon Aug 10 2020 - 12:26:01 EST
On Mon, Aug 10, 2020 at 01:37:47PM +0100, Mark Brown wrote:
> On Sun, Aug 09, 2020 at 10:44:25PM +0300, Dmitry Osipenko wrote:
> > 09.08.2020 22:21, Michał Mirosław пишет:
> > > The code allocates sizeof(regulator_dev) for a pointer. Make it less
> > > generous. Let kcalloc() calculate the size, while at it.
> > >
> > > Cc: stable@xxxxxxxxxxxxxxx
> > > Fixes: d8ca7d184b33 ("regulator: core: Introduce API for regulators coupling customization")
>
> > Hello, Michał! Thank you for the patch! Not sure whether it's worthwhile
> > to backport this change since it's an improvement, I'll leave it to Mark
> > to decide, otherwise looks good to me.
>
> Yeah, this is more a performance improvement than a fix.
Should I resend without Cc: stable?
Best Regards,
Michał Mirosław