Re: [PATCH v1 1/2] ite-it6505 change trigger conditions
From: Sam Ravnborg
Date: Mon Aug 10 2020 - 14:27:18 EST
Hi Allen.
On Mon, Aug 10, 2020 at 05:53:17PM +0800, allen wrote:
> it6505 changes trigger conditions.
> ---
> Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 2c50016..bf0e889 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -73,7 +73,7 @@ examples:
>
> dp-bridge@5c {
> compatible = "ite,it6505";
> - interrupts = <152 IRQ_TYPE_EDGE_FALLING 152 0>;
> + interrupts = <152 IRQ_TYPE_LEVEL_LOW 152 0>;
> reg = <0x5c>;
> pinctrl-names = "default";
> pinctrl-0 = <&it6505_pins>;
I fail to see the need for this. The example shall describe the binding
and is not necessarily a correct description of the HW.
People should look in the dts file for the HW descriptions, not the
binding examples. So I have dropped this patch.
Sam
> --
> 1.9.1