Re: [PATCH 1/2] ASoC: q6afe-dai: add dummy register read function
From: Mark Brown
Date: Tue Aug 11 2020 - 07:37:21 EST
On Tue, Aug 11, 2020 at 01:04:09PM +0200, Stephan Gerhold wrote:
> Actually q6afe-dai does not seem to make use of the register number.
> The DAPM widgets all look like
> SND_SOC_DAPM_AIF_IN("HDMI_RX", NULL, 0, 0, 0, 0),
> /* (wname, stname, wchan, wreg, wshift, winvert)
> Wouldn't it be better to replace wreg = 0 with SND_SOC_NOPM in this case
> so the read/write won't happen at all?
Yes, if they are not used at all then that's what _NOPM is for.
Attachment:
signature.asc
Description: PGP signature