Re: [PATCH 19/20] media: platform: vpdma.c: fix comparison to bool

From: Benoit Parrot
Date: Tue Aug 11 2020 - 08:58:05 EST


Daniel W. S. Almeida <dwlsalmeida@xxxxxxxxx> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
> From: "Daniel W. S. Almeida" <dwlsalmeida@xxxxxxxxx>
>
> Fix the following coccinelle report:
>
> drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
> Comparison to bool
>
> Found using - Coccinelle (http://coccinelle.lip6.fr)
>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@xxxxxxxxx>

Reviewed-by: Benoit Parrot <bparrot@xxxxxx>

> ---
> drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 2e5148ae7a0f..de600ffffbbc 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)
>
> spin_lock_irqsave(&vpdma->lock, flags);
> for (i = 0; i < VPDMA_MAX_NUM_LIST &&
> - vpdma->hwlist_used[i] == true; i++)
> + vpdma->hwlist_used[i]; i++)
> ;
>
> if (i < VPDMA_MAX_NUM_LIST) {
> --
> 2.28.0
>