Re: [PATCH v32 1/6] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

[Dan Murphy]

Pavel

On 8/11/20 5:20 AM, Pavel Machek wrote:
> Hi!
> On Wed 2020-07-22 10:31:41, Dan Murphy wrote:
> > Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024,
> > LP5018, LP5012 and LP5009 RGB LED device driver.  The LP5036/30/24/18/12/9
> > can control RGB LEDs individually or as part of a control bank group.
> > These devices have the ability to adjust the mixing control for the RGB
> > LEDs to obtain different colors independent of the overall brightness of
> > the LED grouping.
> >
> > Datasheet:
> > http://www.ti.com/lit/ds/symlink/lp5012.pdf
> > http://www.ti.com/lit/ds/symlink/lp5024.pdf
> > http://www.ti.com/lit/ds/symlink/lp5036.pdf
> >
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> Acked-by: Pavel Machek <pavel@xxxxxx>
>
> > +           multi-led@1 {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               reg = <0x1>;
> > +               color = <LED_COLOR_ID_MULTI>;
> > +               function = LED_FUNCTION_CHARGING;
> These are just examples, but we should really separate "MULTI" colors
> and "RGB".

If we do then the LP55xx was not updated when the change was made.

I will change it to RGB since I have to touch this file and probably 
submit the LP55xx patch as well.

Dan


> Best regards,
> 									Pavel