Re: [PATCH v2] clk: samsung: Prevent potential endless loop in the PLL set_rate ops

From: Sylwester Nawrocki
Date: Tue Aug 11 2020 - 13:26:14 EST


On 11.08.2020 18:53, Tomasz Figa wrote:
> Yeah... I should've thought about this. Interestingly enough, some of
> the existing implementations in drivers/clk/samsung/clk-pll.c use the
> ktime API. I guess they are lucky enough not to be called too early,
> i.e. are not needed for the initialization of timers.

In normal conditions nothing bad really happens, the loop exits as soon
as the lock bit is asserted. Just the timeout condition will never be
detected - if there is something wrong with the PLL's setup and it never
locks we will never stop polling.

--
Regards,
Sylwester