Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

From: Rajendra Nayak
Date: Wed Aug 12 2020 - 00:31:34 EST



On 8/11/2020 10:42 PM, Matthias Kaehlcke wrote:
On Mon, Aug 10, 2020 at 12:36:19PM +0530, Rajendra Nayak wrote:
dev_pm_opp_set_rate() can now be called with freq = 0 inorder
to either drop performance or bandwidth votes or to disable
regulators on platforms which support them.
In such cases, a subsequent call to dev_pm_opp_set_rate() with
the same frequency ends up returning early because 'old_freq == freq'
Instead make it fall through and put back the dropped performance
and bandwidth votes and/or enable back the regulators.

Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")
Reported-by: Sajida Bhanu <sbhanu@xxxxxxxxxxxxxx>
Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>

Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>

Originally-reported-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
https://patchwork.kernel.org/patch/11675369/#23514895 :P

Sorry to have missed that :/
Thanks for testing.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation