Re: [PATCH v3 0/8] huge vmalloc mappings
From: Nicholas Piggin
Date: Wed Aug 12 2020 - 04:11:34 EST
Excerpts from Zefan Li's message of August 12, 2020 11:07 am:
> On 2020/8/12 0:32, Jonathan Cameron wrote:
>> On Mon, 10 Aug 2020 12:27:24 +1000
>> Nicholas Piggin <npiggin@xxxxxxxxx> wrote:
>>
>>> Not tested on x86 or arm64, would appreciate a quick test there so I can
>>> ask Andrew to put it in -mm. Other option is I can disable huge vmallocs
>>> for them for the time being.
>>
>> Hi Nicholas,
>>
>> For arm64 testing with a Kunpeng920.
>>
>> I ran a quick sanity test with this series on top of mainline (yes mid merge window
>> so who knows what state is...). Could I be missing some dependency?
>>
>> Without them it boots, with them it doesn't. Any immediate guesses?
>>
>
> I've already reported this bug in v2, and yeah I also tested it on arm64
> (not Kunpeng though), so looks like it still hasn't been fixed.
Huh, I thought I did fix it but seems not. vmap stacks shouldn't be
big enough to use huge pages though, so I don't know what's going on
there. I'll dig around a bit more.
>
> ...
>>>
>>> Since v2:
>>> - Rebased on vmalloc cleanups, split series into simpler pieces.
>>> - Fixed several compile errors and warnings
>>> - Keep the page array and accounting in small page units because
>>> struct vm_struct is an interface (this should fix x86 vmap stack debug
>>> assert). [Thanks Zefan]
>
> though the changelog says it's fixed for x86.
Yes, my mistake that was supposed to say arm64.
Thanks,
Nick