Re: [PATCH v8 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster

[Sergei Shtylyov]

Hello!

On 12.08.2020 10:19, Wesley Cheng wrote:

> Add the required DTS node for the USB VBUS output regulator, which is
> available on PM8150B.  This will provide the VBUS source to connected
> peripherals.
>
> Signed-off-by: Wesley Cheng <wcheng@xxxxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/pm8150b.dtsi   | 6 ++++++
>   arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++++
>   2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> index 053c659734a7..9e560c1ca30d 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -53,6 +53,12 @@ power-on@800 {
>   			status = "disabled";
>   		};
>   
> +		pm8150b_vbus: dcdc@1100 {

   s/dcdc/regulator/? What is "dcdc", anyway?
   The device nodes must have the generic names, according to the DT spec.

> +			compatible = "qcom,pm8150b-vbus-reg";
> +			status = "disabled";
> +			reg = <0x1100>;
> +		};
> +
>   		pm8150b_typec: typec@1500 {
>   			compatible = "qcom,pm8150b-usb-typec";
>   			status = "disabled";
[...]

MBR, Sergei