Re: Aw: [PATCH 3/3] mmc: mediatek: add optional module reset property

From: Wenbin Mei
Date: Wed Aug 12 2020 - 07:56:58 EST


Thanks for your reply.
I will add this in the next version.
On Wed, 2020-08-12 at 12:07 +0200, Frank Wunderlich wrote:
> > Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> > Von: "Wenbin Mei" <wenbin.mei@xxxxxxxxxxxx>
> > Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property
>
> > This patch adds a optional reset management for msdc.
> > Sometimes the bootloader does not bring msdc register
> > to default state, so need reset the msdc controller.
> >
> > Signed-off-by: Wenbin Mei <wenbin.mei@xxxxxxxxxxxx>
>
> Thanks for posting the fix to Mainline
>
> imho this should contain a fixes-Tag as it fixes eMMC-Access on mt7622/Bpi-R64
>
> before we got these Errors on mounting eMMC ion R64:
>
> [ 48.664925] blk_update_request: I/O error, dev mmcblk0, sector 204800 op 0x1:(WRITE) flags 0x800 phys_seg 1 prio class 0
> [ 48.676019] Buffer I/O error on dev mmcblk0p1, logical block 0, lost sync page write
>
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Tested-By: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> and it needs to be fixed at least for 5.4+, so adding stable-CC
>
> Cc: stable@xxxxxxxxxxxxxxx