Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

[Sibi Sankar]

Hey Stephen,
Thanks for taking time to review the
series!

On 2020-08-12 03:08, Stephen Boyd wrote:
> Quoting Sibi Sankar (2020-08-11 12:02:51)
> > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> > index ee11502a575b0..3002a2d68936a 100644
> > --- a/include/linux/pm_domain.h
> > +++ b/include/linux/pm_domain.h
> > @@ -55,6 +55,10 @@
> >   *
> >   * GENPD_FLAG_RPM_ALWAYS_ON:   Instructs genpd to always keep the PM 
> > domain
> >   *                             powered on except for system suspend.
> > + *
> > + * GENPD_FLAG_SUSPEND_ON:      Instructs genpd to keep the PM domain 
> > powered
> > + *                             on during suspend and runtime PM 
> > controlled
>
> Maybe, "powered on across system suspend (if it is already powered on)"
> to match the hunk above that talks about system suspend for
> GENPD_FLAG_RPM_ALWAYS_ON. Otherwise someone may think that this powers
> on the genpd during suspend or powers it on during runtime suspend.

Sure, I'll add ^^ in the next re-spin.

> > + *                             otherwise.
> >   */
> >  #define GENPD_FLAG_PM_CLK       (1U << 0)
> >  #define GENPD_FLAG_IRQ_SAFE     (1U << 1)

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.