Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options

[David Lechner]

On 8/12/20 8:37 AM, Alex Dewar wrote:
> On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote:
> > On 8/9/20 1:54 PM, Alex Dewar wrote:
> > > This battery appears only to be used by a single board (DA850), so it
> > > makes sense to add this to the Kconfig file so that users don't build
> > > the module unnecessarily. It currently seems to be built for the x86
> > > Arch Linux kernel where it's probably not doing much good.
> >
> > It would probably also make sense to add "default n" since it only
> > applies to one board in the entire arch.
>
> Ah ok. That makes sense. Would you like me to send a follow-on patch for
> this?

You can just send a v2 patch that includes the change below and the
additional change.

> Alex
>
> > BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate
> > defconfig file, so I don't think it would break anything.
> >
> > > Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx>
> > > ---
> > >    drivers/power/supply/Kconfig | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> > > index faf2830aa1527..9f76e2f47ac6d 100644
> > > --- a/drivers/power/supply/Kconfig
> > > +++ b/drivers/power/supply/Kconfig
> > > @@ -164,7 +164,7 @@ config BATTERY_DS2782
> > >    config BATTERY_LEGO_EV3
> > >    	tristate "LEGO MINDSTORMS EV3 battery"
> > > -	depends on OF && IIO && GPIOLIB
> > > +	depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST)
> > >    	help
> > >    	  Say Y here to enable support for the LEGO MINDSTORMS EV3 battery.