Re: [PATCH v5 1/3] arm64: dts: Add a device tree for the Librem 5 phone

[Martin Kepplinger]

On 31.07.20 10:27, Martin Kepplinger wrote:
> From: "Angus Ainslie (Purism)" <angus@xxxxxxxx>
> 
> Add a devicetree description for the Librem 5 phone. 4 hardware revisions
> have been available. Some revisions include changes that need different
> software to be run. So far, r3 ("Dogwood") is one such example, see:
> 
> 	"Aspen"		r0	not supported (very few devices exist)
> 	"Birch"		r1	supported by r2
> 	"Chestnut"	r2	added by this patch
> 	"Dogwood"	r3	added by this patch
> 	"Evergreen"	r4	tba / most likely supported by r3
> 
> See https://puri.sm/products/librem-5/ for more information.
> 
> This boots to a working console with working WWAN modem, wifi usdhc,
> IMU sensor device, proximity sensor, haptic motor, gpio keys, GNSS and LEDs.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> Signed-off-by: Angus Ainslie (Purism) <angus@xxxxxxxx>
> Signed-off-by: Guido Günther <agx@xxxxxxxxxxx>
> For audio related part:
> Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
> 
> 
> revision history
> ----------------
> v5:
> thanks a lot Pavel for reviewing again
>  * remove pwmleds (no stable interface yet)
> 
> v4:
> thanks a lot Shawn for reviewing
>  * rename to dtsi and split out r2 and r3 dts with revision specifics
>  * add the USB2642 hard-wired Hub
>  * fix charge controller boost-max-current
>  * disable pullup on CHRG_INT (not needed due to external one)
>  * add documentation for the boards' compatible strings
>  * fix led-backlight propery usage
>  * coding style fixes
> https://lore.kernel.org/linux-devicetree/20200721153225.7593-1-martin.kepplinger@xxxxxxx/T/
> 
> v3:
> thanks a lot Mark for reviewing! changes since v2:
>  * nicer audio cards names
>  * squash unneeded audio_pwr regulator
>  * remove the susphy_quirk from dwc3_1 after more testing
>  * add usdhc2 card detect via gpio
>  * add headphone detect for audio card
> https://lore.kernel.org/linux-arm-kernel/20200617073821.16737-1-martin.kepplinger@xxxxxxx/T/
> 
> v2:
> thanks a lot Marco, Daniel and Pavel for reviewing. changes since v1:
>  * alphabetical sortings / more consistent node names
>  * remove unused regulator and pinctrl descriptions
>  * generic labels for leds, backlight, flash and torch
>  * audio clk settings moved to sai2 node
> https://lore.kernel.org/linux-arm-kernel/20200604084756.586-1-martin.kepplinger@xxxxxxx/T/
> 
> v1:
> https://lore.kernel.org/linux-arm-kernel/20200514155737.12160-1-martin.kepplinger@xxxxxxx/
> 

hi Shawn, hi all,

the merge window is basically over and maybe you'll then find time to
review whether you still find problems with this addition. In case
you've looked at an older version of this, all changes should be listed
in the revision history above.

thanks again,
                                 martin