Re: [PATCH] drivers: crypto: picoxcell_crypto: Fix potential race condition bug

From: Jamie Iles
Date: Thu Aug 13 2020 - 07:33:10 EST


On Tue, Aug 11, 2020 at 06:00:24PM +0530, madhuparnabhowmik10@xxxxxxxxx wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
>
> engine->stat_irq_thresh was initialized after device_create_file() in
> the probe function, the initialization may race with call to
> spacc_stat_irq_thresh_store() which updates engine->stat_irq_thresh,
> therefore initialize it before creating the file in probe function.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>

Acked-by: Jamie Iles <jamie@xxxxxxxxxxxxx>

Thanks!