Re: [PATCH][v2] proc: use vmalloc for our kernel buffer

[Josef Bacik]

On 8/13/20 5:10 PM, David Laight wrote:
> From: Josef Bacik
> > Sent: 13 August 2020 18:19
> ...
> > We wouldn't even need the extra +1 part, since we're only copying in how much
> > the user wants anyway, we could just go ahead and convert this to
> >
> > left -= snprintf(buffer, left, "0x%04x\n", *(unsigned int *) table->data);
> >
> > and be fine, right?  Or am I misunderstanding what you're looking for?  Thanks,
>
> Doesn't that need to be scnprintf()?
> IIRC snprintf() returns the number of bytes that would have been
> written were the buffer infinite size?
> (I suspect this is an 'accidental' return value from the original
> SYSV? userspace implementation that just dumped characters that
> wouldn't fit in the buffer somewhere.)

Yeah, if you look at the patches I just sent you'll notice I used scnprintf() 
everywhere.  Thanks,

Josef