Re: [PATCH v5 02/17] ARM: Revert back to default scheduler topology.

[Valentin Schneider]

On 13/08/20 20:16, Ingo Molnar wrote:
> * Valentin Schneider <valentin.schneider@xxxxxxx> wrote:
>
>> The ARM-specific GMC level is meant to be built using the thread sibling
>> mask, but no devicetree in arch/arm/boot/dts uses the 'thread' cpu-map
>> binding. With SD_SHARE_POWERDOMAIN gone, this topology level can be
>> removed, at which point ARM no longer benefits from having a custom defined
>> topology table.
>>
>> Delete the GMC topology level by making ARM use the default scheduler
>> topology table. This essentially reverts commit
>>
>>   fb2aa85564f4 ("sched, ARM: Create a dedicated scheduler topology table")
>>
>> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
>> Suggested-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
>> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
>> Signed-off-by: Valentin Schneider <valentin.schneider@xxxxxxx>
>
> Minor changelog nit, it's helpful to add this final sentence:
>
>     No change in functionality is expected.
>
> ( If indeed no change in functionality is expected. ;-)
>

Right, that's indeed the case here given the GMC domain would always be
degenerated anyway.

> Thanks,
>
>       Ingo