Re: POC: Alternative solution: Re: [PATCH 0/4] printk: reimplement LOG_CONT handling

From: John Ogness
Date: Fri Aug 14 2020 - 04:16:40 EST


On 2020-08-14, Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote:
> One thing that we need to handle here, I believe, is that the context
> which crashes the kernel should flush its cont buffer, because the
> information there is relevant to the crash:
>
> pr_cont_alloc_info(&c);
> pr_cont(&c, "1");
> pr_cont(&c, "2");
> >>
> oops
> panic()
> <<
> pr_cont_flush(&c);
>
> We better flush that context's pr_cont buffer during panic().

I am not convinced of the general usefulness of partial messages, but as
long as we have an API that includes registration, usage, and
deregistration of some sort of handle, then we leave the window open for
such implementations.

John Ogness