Re: [PATCH] nvme-pci: cancel nvme device request before disabling

[Tong Zhang]

Oops sorry for the duplicated email -- I forgot to turn off HTML when
sending the previous one.

Thanks Christoph,
I did a couple of fixes on the commit log, please see v2 patch.
Thanks!
-- Tong


On Fri, Aug 14, 2020 at 4:16 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote:
> >   This patch addresses an irq free warning and null pointer dereference
> >   error problem when nvme devices got timeout error during initialization.
> >   This problem happens when nvme_timeout() function is called while
> >   nvme_reset_work() is still in execution. This patch fixed the problem by
> >   setting flag of the problematic request to NVME_REQ_CANCELLED before
> >   calling nvme_dev_disable() to make sure __nvme_submit_sync_cmd() returns
> >   an error code and let nvme_submit_sync_cmd() fail gracefully.
> >   The following is console output.
>
> The commit log looks a little weird due to the extra indentation.
>
> The patch itself looks good, though:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>