Re: [PATCH 8/8] locking/atomics: Use read-write instrumentation for atomic RMWs
From: Marco Elver
Date: Fri Aug 14 2020 - 07:59:24 EST
On Fri, 14 Aug 2020 at 13:31, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> On Fri, Aug 14, 2020 at 12:28:26PM +0100, Mark Rutland wrote:
> > Hi,
> > Sorry to come to this rather late -- this comment equally applies to v2
> > so I'm replying here to have context.
> ... and now I see that was already applied, so please ignore this!
Thank you for the comment anyway. If this is something urgent, we
could send a separate patch to change.
My argument in favour of keeping it as-is was that the alternative
would throw away the "type" and we no longer recognize a difference
between arguments (in fairness, currently not important though). If,
say, we get an RMW that has a constant argument though, the current
version would do the "right thing" as far as I can tell. Maybe I'm
overly conservative here, but it saves us worrying about some future
use-case breaking this more than before.