Re: [PATCH v4 0/2] dma-pool fixes

From: Amit Pundir
Date: Fri Aug 14 2020 - 09:19:15 EST


On Fri, 14 Aug 2020 at 15:56, Nicolas Saenz Julienne
<nsaenzjulienne@xxxxxxx> wrote:
>
> Now that we have an explanation to Amir's issue, we can re-spin this
> series.

Hi, Smoke tested (boots AOSP to UI with Touch/WiFi/BT working) on my
Poco F1 phone, with upstream commit 00e4db51259a (+ 30 odd out of
tree patches [1]) and I see no obvious regressions.

For both the patches in the series:

Tested-by: Amit Pundir <amit.pundir@xxxxxxxxxx>

[1] https://github.com/pundiramit/linux/commits/beryllium-mainline-display


>
> ---
> Changes since v3:
> - Do not use memblock_start_of_DRAM()
>
> Changes since v2:
> - Go back to v1's behavior for patch #2
>
> Changes since v1:
> - Make cma_in_zone() more strict, GFP_KERNEL doesn't default to true
> now
>
> - Check if phys_addr_ok() exists prior calling it
>
> Christoph Hellwig (1):
> dma-pool: fix coherent pool allocations for IOMMU mappings
>
> Nicolas Saenz Julienne (1):
> dma-pool: Only allocate from CMA when in same memory zone
>
> drivers/iommu/dma-iommu.c | 4 +-
> include/linux/dma-direct.h | 3 -
> include/linux/dma-mapping.h | 5 +-
> kernel/dma/direct.c | 13 +++-
> kernel/dma/pool.c | 145 +++++++++++++++++++-----------------
> 5 files changed, 92 insertions(+), 78 deletions(-)
>
> --
> 2.28.0
>