Re: [kbuild-all] Re: fs/ocfs2/suballoc.c:2430:2-8: preceding lock on line 2413

[Philip Li]

On Fri, Aug 14, 2020 at 09:52:13PM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 14 Aug 2020, Thomas Gleixner wrote:
> 
> > Julia,
> >
> > On Fri, Aug 14 2020 at 21:00, Julia Lawall wrote:
> > > On Fri, 14 Aug 2020, Thomas Gleixner wrote:
> > >> That's clearly a false positive. Is there anything what can be done to
> > >> help that cocci script here?
> > >
> > > I have a better version that needs to get pushed.
> > >
> > > But normally these pass through me.  Did you get it directly from kbuild?
> >
> > Yes, because I touched the affected lines last :)
> 
> Actually, that's not the point.  Normally, I get all the reports on this
> case, and then I forward them if they look ok.  If I forwarded something
> incorrect, then sorry about that.  If the policy has changed for this rule
> to be sending the reports out directlty to the recipients, then I think it
> should be changed back.  There are a lot of real bugs with lock usage, but
> there are alot of false positives too.  Specifically, the rule looks for
> the case with identical if tests, but only when the branches are identical
> too.
> 
> Kbuild people, can this be adjusted?  Or have I misunderstood the
> situation?
Hi Julia and Thomas, pls allow us to check this further, usually all cocci
reports will be sent to kbuild@xxxxxx for Julia to check. But there maybe
something wrong with this report. We will check the detail in next week as
we have server maintainance during the weekend.

> 
> thanks,
> julia
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@xxxxxxxxxxxx
> To unsubscribe send an email to kbuild-all-leave@xxxxxxxxxxxx