Re: [PATCH 1/3] staging: androind: Replace BUG_ONs with WARN_ONs

[kernel test robot]

Hi Tomer,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.8 next-20200814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tomer-Samara/Replac-BAG-BAG_ON-with-WARN-WARN_ON/20200817-012333
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 86cfccb66937dd6cbf26ed619958b9e587e6a115
config: x86_64-randconfig-a011-20200817 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ab9fc8bae805c785066779e76e7846aabad5609e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/staging/android/ion/ion_page_pool.c:50:15: error: expected ';' after return statement
                           return NULL:
                                      ^
                                      ;
   1 error generated.

# https://github.com/0day-ci/linux/commit/71d27df2e46fe435ada18ac3dae964d6b9a74664
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tomer-Samara/Replac-BAG-BAG_ON-with-WARN-WARN_ON/20200817-012333
git checkout 71d27df2e46fe435ada18ac3dae964d6b9a74664
vim +50 drivers/staging/android/ion/ion_page_pool.c

    43	
    44	static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)
    45	{
    46		struct page *page;
    47	
    48		if (high) {
    49			if (WARN_ON(!pool->high_count))
  > 50				return NULL:
    51			page = list_first_entry(&pool->high_items, struct page, lru);
    52			pool->high_count--;
    53		} else {
    54			if (WARN_ON(!pool->low_count))
    55				return NULL;
    56			page = list_first_entry(&pool->low_items, struct page, lru);
    57			pool->low_count--;
    58		}
    59	
    60		list_del(&page->lru);
    61		mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE,
    62				    -(1 << pool->order));
    63		return page;
    64	}
    65	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip