Re: [PATCH v3] ata: use generic power management

From: Jens Axboe
Date: Mon Aug 17 2020 - 10:06:15 EST


On 8/17/20 2:25 AM, Vaibhav Gupta wrote:
> Hello,
>
> I am working to upgrade power management framework support for PCI drivers, as
> my project under the Linux Kernel Mentorship Program.
>
> The ultimate goal is to completely remove the legacy framework. And for this we
> need to remove ".suspend" and ".resume" pointers from "struct pci_driver".
>
> The patch is doing the change for the same. The actual suspend() and
> resume() callbacks are defined in drivers/ata/libata-core.c and are exported.
> Which are then used by other files.
>
> Thus removing those pointers, included 54 files in this patch. Although, the
> actual changes are done in few files only. The changes should work fine as I
> have done similar changes for other drivers too which made their way into the
> kernel. Still, tests on few ata devices are necessary.

Didn't we agree to split this up into separate patches??

> I tried but unfortunately, I couldn't find or arrange devices to test upon. I
> have added the authors of the previous commit(s) for respective drivers as
> recipients. It would be very helpful if someone can test it on a device.

Does qemu support any of the affected drivers?

--
Jens Axboe