Re: [PATCH] tty: serial: fix earlycon dependency

[Tong Zhang]

On Mon, Aug 17, 2020 at 1:00 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> We can handle lines 72 characters long :)
OK, thanks, I was not aware of that, I will reformat the text in the
next version

> > Signed-off-by: Tong Zhang <ztong0001@xxxxxxxxx>
>
> What broke to cause this to be needed?

newbie here, please don't laugh at me,
I just followed what people were doing after read some articles from
the internet

> Can you provide a "Fixes:" tag for this?
sure, thanks for the suggestion

>
> > ---
> >  drivers/tty/serial/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 8a0352eb337c..42e844314cbb 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -8,6 +8,7 @@ menu "Serial drivers"
> >
> >  config SERIAL_EARLYCON
> >       bool
> > +     select SERIAL_CORE
>
> Are you _sure_ about this?  This feels odd...

Yeah.. that also seems odd to me -- this bug can be triggered under
some corner cases
which I haven't figured out why --
I can encounter this problem when doing allmodconfig followed by some random
select/deselect in menuconfig. -- It seems that menuconfig is not
doing some dependency
check correctly, i.e. when SERIAL_CORE is not builtin, SERIAL_EARLYCON
should not
be selected either.
What do you suggest?

> thanks,
Thank you.

> greg k-h