Re: [PATCH v3] net: qrtr: fix usage of idr in port assignment to socket

[David Miller]

From: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>
Date: Mon, 17 Aug 2020 15:54:48 +0000

> From: Necip Fazil Yildiran <necip@xxxxxxxxxx>
> 
> Passing large uint32 sockaddr_qrtr.port numbers for port allocation
> triggers a warning within idr_alloc() since the port number is cast
> to int, and thus interpreted as a negative number. This leads to
> the rejection of such valid port numbers in qrtr_port_assign() as
> idr_alloc() fails.
> 
> To avoid the problem, switch to idr_alloc_u32() instead.
> 
> Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
> Reported-by: syzbot+f31428628ef672716ea8@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Necip Fazil Yildiran <necip@xxxxxxxxxx>
> Reviewed-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>

Applied and queued up for -stable, thank you.