Re: [PATCH] Makefile: Yes. Finally remove '-Wdeclaration-after-statement'

[Pavel Machek]

On Mon 2020-08-17 14:29:37, Linus Torvalds wrote:
> On Mon, Aug 17, 2020 at 2:15 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
> >
> > Does anyone remember why we added this warning?  I had always thought
> > it's purpose was to ensure we stayed within our chosen dialect of C.
> 
> As far as I'm concerned, that's the primary motivation.
> 
> I'm not seeing why we'd suddenly allow the "put variable declarations
> anywhere" when we've been able to keep from doing it until now.
> 
> We're still building primarily good old K&R ANSI C, just with
> extensions. Wild variable placement doesn't seem like a useful
> extension.

I certainly hope we are not going back to good old K&R C :-).

Submitter believes "wild variable placement" can help with
#ifdefs.. and that may be actually good tradeoff.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature