Re: [PATCH v5 1/3] perf jevents: Add support for parsing perchip/percore events

[kajoljain]

On 8/16/20 10:05 PM, Andi Kleen wrote:
>> @@ -321,7 +331,7 @@ static void print_events_table_prefix(FILE *fp, const char *tblname)
>>  static int print_events_table_entry(void *data, char *name, char *event,
>>  				    char *desc, char *long_desc,
>>  				    char *pmu, char *unit, char *perpkg,
>> -				    char *metric_expr,
>> +				    char *metric_expr, char *aggr_mode,
>>  				    char *metric_name, char *metric_group,
>>  				    char *deprecated, char *metric_constraint)
> 
> We should really define a struct now to pass the parameters,
> the callback prototype is getting ridiculous.
> 
> I know it's my fault originally, but sorry you probably have to do it
> because you are touching it last.

Hi Andi,
   I will look into it.

Thanks,
Kajol Jain
> 
> -Andi
>