drivers/gpu/drm/qxl/qxl_kms.c:277:21: sparse: sparse: incorrect type in argument 1 (different address spaces)

From: kernel test robot
Date: Tue Aug 18 2020 - 05:59:29 EST

Next message:
Previous
Messages

tree: config: m68k-randconfig-s032-20200818 compiler: m68k-linux-gcc reproduce:
wget # apt-get install sparse
# sparse version: git checkout # save the COMPILER_INSTALL_PATH=$HOME/0day
If you fix the issue, Reported-by: kernel

sparse warnings: (new
drivers/gpu/drm/qxl/qxl_kms.c:36:5: drivers/gpu/drm/qxl/qxl_kms.c:170:19: drivers/gpu/drm/qxl/qxl_kms.c:170:19: drivers/gpu/drm/qxl/qxl_kms.c:170:19: drivers/gpu/drm/qxl/qxl_kms.c:188:26: drivers/gpu/drm/qxl/qxl_kms.c:188:26: drivers/gpu/drm/qxl/qxl_kms.c:188:26: >> drivers/gpu/drm/ >> drivers/gpu/drm/ drivers/gpu/drm/qxl/qxl_kms.c:277:21: >> drivers/gpu/drm/ drivers/gpu/drm/qxl/qxl_kms.c:281:21: drivers/gpu/drm/qxl/qxl_kms.c:281:21: drivers/gpu/drm/qxl/qxl_kms.c:301:21: drivers/gpu/drm/qxl/qxl_kms.c:301:21: drivers/gpu/drm/qxl/qxl_kms.c:301:21: drivers/gpu/drm/qxl/qxl_kms.c:302:21: drivers/gpu/drm/qxl/qxl_kms.c:302:21: drivers/gpu/drm/qxl/qxl_kms.c:302:21:
# git checkout 670d0a4b1070466 vim +277 drivers/gpu/drm/qxl
f64122c1f6ade3 Dave Airlie 2b65d5677a797f Gabriel aa5b62bac05d4b Gabriel f64122c1f6ade3 Dave Airlie 35541782dcc1e5 Gerd Hoffmann f64122c1f6ade3 Dave Airlie cbdded7f8a633e Gabriel cbdded7f8a633e Gabriel cbdded7f8a633e Gabriel f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie b3740e88601d69 Christophe Fergeau f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev a9b0b24a6fff2d Daniel Vetter 5043348a4969ae Anton Vasilyev 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann 970fa986fadb11 Dave Airlie 970fa986fadb11 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 970fa986fadb11 Dave Airlie 35541782dcc1e5 Gerd Hoffmann f64122c1f6ade3 Dave Airlie 35541782dcc1e5 Gerd Hoffmann 35541782dcc1e5 Gerd Hoffmann f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev dbe3ad61dcebc4 Markus Elfring 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 80e5f89da3ab94 Huacai Chen f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 2f453ed4038526 Maarten Lankhorst f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 2ec6bd67b76ea0 Gerd Hoffmann 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 2ec6bd67b76ea0 Gerd Hoffmann f64122c1f6ade3 Dave Airlie 2ec6bd67b76ea0 Gerd Hoffmann 2ec6bd67b76ea0 Gerd Hoffmann d9bbf1895f354c Gerd Hoffmann d9bbf1895f354c Gerd Hoffmann f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev 5043348a4969ae Anton Vasilyev f64122c1f6ade3 Dave Airlie f64122c1f6ade3 Dave Airlie
:::::: The code at :::::: 5043348a4969ae1661c00
:::::: TO: Anton Vasilyev :::::: CC: Gerd Hoffmann
---
0-DAY CI Kernel Test Attachment: Description: application/gzip peterz: "Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control" message: Vinod Koul: "Re: [PATCH v3] usb: renesas-xhci: remove version check" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
ac2ceb6c7cf6c2b75cdd
7d18f7592993d02783aa sparse: use identifiers to define address spaces
(attached as .config)
(GCC) 9.3.0
href="https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
v0.6.2-180-g49f7e13a-dirty
670d0a4b10704667765f7d18f7592993d02783aa
attached .config to linux build tree
COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=m68k
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
ones prefixed by >>)
sparse: sparse: symbol 'qxl_log_level' was not declared. Should it be static?
sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct qxl_rom *rom @@ got void [noderef] __iomem * @@
sparse: expected struct qxl_rom *rom
sparse: got void [noderef] __iomem *
sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct qxl_ram_header *ram_header @@ got void [noderef] __iomem * @@
sparse: expected struct qxl_ram_header *ram_header
sparse: got void [noderef] __iomem *
qxl/qxl_kms.c:277:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got struct qxl_ram_header *ram_header @@
qxl/qxl_kms.c:277:21: sparse: expected void [noderef] __iomem *addr
sparse: got struct qxl_ram_header *ram_header
qxl/qxl_kms.c:281:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got struct qxl_rom *rom @@
sparse: expected void [noderef] __iomem *addr
sparse: got struct qxl_rom *rom
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got struct qxl_ram_header *ram_header @@
sparse: expected void [noderef] __iomem *addr
sparse: got struct qxl_ram_header *ram_header
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got struct qxl_rom *rom @@
sparse: expected void [noderef] __iomem *addr
sparse: got struct qxl_rom *rom
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=670d0a4b10704667765f7d18f7592993d02783aa">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=670d0a4b10704667765f7d18f7592993d02783aa
rel="nofollow" href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
7765f7d18f7592993d02783aa
/qxl_kms.c
2013-02-25 109
Krisman Bertazi 2017-01-19 110 int qxl_device_init(struct qxl_device *qdev,
Krisman Bertazi 2017-02-27 111 struct pci_dev *pdev)
2013-02-25 112 {
2013-10-11 113 int r, sb;
2013-02-25 114
Krisman Bertazi 2017-01-26 115 qdev->ddev.pdev = pdev;
Krisman Bertazi 2017-01-26 116 pci_set_drvdata(pdev, &qdev->ddev);
Krisman Bertazi 2017-01-26 117
2013-02-25 118 mutex_init(&qdev->gem.mutex);
2013-02-25 119 mutex_init(&qdev->update_area_mutex);
2013-02-25 120 mutex_init(&qdev->release_mutex);
2013-02-25 121 mutex_init(&qdev->surf_evict_mutex);
2016-11-08 122 qxl_gem_init(qdev);
2013-02-25 123
2013-02-25 124 qdev->rom_base = pci_resource_start(pdev, 2);
2013-02-25 125 qdev->rom_size = pci_resource_len(pdev, 2);
2013-02-25 126 qdev->vram_base = pci_resource_start(pdev, 0);
2013-02-25 127 qdev->io_base = pci_resource_start(pdev, 3);
2013-02-25 128
2013-02-25 129 qdev->vram_mapping = io_mapping_create_wc(qdev->vram_base, pci_resource_len(pdev, 0));
2018-07-27 130 if (!qdev->vram_mapping) {
2018-07-27 131 pr_err("Unable to create vram_mapping");
2020-04-15 132 return -ENOMEM;
2018-07-27 133 }
2013-10-11 134
2013-10-11 135 if (pci_resource_len(pdev, 4) > 0) {
2013-10-11 136 /* 64bit surface bar present */
2013-10-11 137 sb = 4;
2013-10-11 138 qdev->surfaceram_base = pci_resource_start(pdev, sb);
2013-10-11 139 qdev->surfaceram_size = pci_resource_len(pdev, sb);
2013-10-11 140 qdev->surface_mapping =
2013-10-11 141 io_mapping_create_wc(qdev->surfaceram_base,
2013-10-11 142 qdev->surfaceram_size);
2013-10-11 143 }
2013-10-11 144 if (qdev->surface_mapping == NULL) {
2013-10-11 145 /* 64bit surface bar not present (or mapping failed) */
2013-10-11 146 sb = 1;
2013-10-11 147 qdev->surfaceram_base = pci_resource_start(pdev, sb);
2013-10-11 148 qdev->surfaceram_size = pci_resource_len(pdev, sb);
2013-10-11 149 qdev->surface_mapping =
2013-10-11 150 io_mapping_create_wc(qdev->surfaceram_base,
2013-10-11 151 qdev->surfaceram_size);
2018-07-27 152 if (!qdev->surface_mapping) {
2018-07-27 153 pr_err("Unable to create surface_mapping");
2018-07-27 154 r = -ENOMEM;
2018-07-27 155 goto vram_mapping_free;
2018-07-27 156 }
2013-10-11 157 }
2013-10-11 158
2013-10-11 159 DRM_DEBUG_KMS("qxl: vram %llx-%llx(%dM %dk), surface %llx-%llx(%dM %dk, %s)\n",
2013-05-31 160 (unsigned long long)qdev->vram_base,
2013-05-31 161 (unsigned long long)pci_resource_end(pdev, 0),
2013-02-25 162 (int)pci_resource_len(pdev, 0) / 1024 / 1024,
2013-02-25 163 (int)pci_resource_len(pdev, 0) / 1024,
2013-05-31 164 (unsigned long long)qdev->surfaceram_base,
2013-10-11 165 (unsigned long long)pci_resource_end(pdev, sb),
2013-02-25 166 (int)qdev->surfaceram_size / 1024 / 1024,
2013-10-11 167 (int)qdev->surfaceram_size / 1024,
2013-10-11 168 (sb == 4) ? "64bit" : "32bit");
2013-02-25 169
2013-02-25 170 qdev->rom = ioremap(qdev->rom_base, qdev->rom_size);
2013-02-25 171 if (!qdev->rom) {
2013-02-25 172 pr_err("Unable to ioremap ROM\n");
2018-07-27 173 r = -ENOMEM;
2018-07-27 174 goto surface_mapping_free;
2013-02-25 175 }
2013-02-25 176
2018-07-27 177 if (!qxl_check_device(qdev)) {
2018-07-27 178 r = -ENODEV;
2019-11-07 179 goto rom_unmap;
2018-07-27 180 }
2013-02-25 181
2013-02-25 182 r = qxl_bo_init(qdev);
2013-02-25 183 if (r) {
2013-02-25 184 DRM_ERROR("bo init failed %d\n", r);
2018-07-27 185 goto rom_unmap;
2013-02-25 186 }
2013-02-25 187
2013-02-25 188 qdev->ram_header = ioremap(qdev->vram_base +
2013-02-25 189 qdev->rom->ram_header_offset,
2013-02-25 190 sizeof(*qdev->ram_header));
2018-07-27 191 if (!qdev->ram_header) {
2018-07-27 192 DRM_ERROR("Unable to ioremap RAM header\n");
2018-07-27 193 r = -ENOMEM;
2018-07-27 194 goto bo_fini;
2018-07-27 195 }
2013-02-25 196
2013-02-25 197 qdev->command_ring = qxl_ring_create(&(qdev->ram_header->cmd_ring_hdr),
2013-02-25 198 sizeof(struct qxl_command),
2013-02-25 199 QXL_COMMAND_RING_SIZE,
2013-02-25 200 qdev->io_base + QXL_IO_NOTIFY_CMD,
2013-02-25 201 false,
2013-02-25 202 &qdev->display_event);
2018-07-27 203 if (!qdev->command_ring) {
2018-07-27 204 DRM_ERROR("Unable to create command ring\n");
2018-07-27 205 r = -ENOMEM;
2018-07-27 206 goto ram_header_unmap;
2018-07-27 207 }
2013-02-25 208
2013-02-25 209 qdev->cursor_ring = qxl_ring_create(
2013-02-25 210 &(qdev->ram_header->cursor_ring_hdr),
2013-02-25 211 sizeof(struct qxl_command),
2013-02-25 212 QXL_CURSOR_RING_SIZE,
2020-03-31 213 qdev->io_base + QXL_IO_NOTIFY_CURSOR,
2013-02-25 214 false,
2013-02-25 215 &qdev->cursor_event);
2013-02-25 216
2018-07-27 217 if (!qdev->cursor_ring) {
2018-07-27 218 DRM_ERROR("Unable to create cursor ring\n");
2018-07-27 219 r = -ENOMEM;
2018-07-27 220 goto command_ring_free;
2018-07-27 221 }
2018-07-27 222
2013-02-25 223 qdev->release_ring = qxl_ring_create(
2013-02-25 224 &(qdev->ram_header->release_ring_hdr),
2013-02-25 225 sizeof(uint64_t),
2013-02-25 226 QXL_RELEASE_RING_SIZE, 0, true,
2013-02-25 227 NULL);
2013-02-25 228
2018-07-27 229 if (!qdev->release_ring) {
2018-07-27 230 DRM_ERROR("Unable to create release ring\n");
2018-07-27 231 r = -ENOMEM;
2018-07-27 232 goto cursor_ring_free;
2018-07-27 233 }
2013-02-25 234
2013-02-25 235 idr_init(&qdev->release_idr);
2013-02-25 236 spin_lock_init(&qdev->release_idr_lock);
2014-04-02 237 spin_lock_init(&qdev->release_lock);
2013-02-25 238
2013-02-25 239 idr_init(&qdev->surf_id_idr);
2013-02-25 240 spin_lock_init(&qdev->surf_id_idr_lock);
2013-02-25 241
2013-02-25 242 mutex_init(&qdev->async_io_mutex);
2013-02-25 243
2013-02-25 244 /* reset the device into a known state - no memslots, no primary
2013-02-25 245 * created, no surfaces. */
2013-02-25 246 qxl_io_reset(qdev);
2013-02-25 247
2013-02-25 248 /* must initialize irq before first async io - slot creation */
2013-02-25 249 r = qxl_irq_init(qdev);
2018-07-27 250 if (r) {
2018-07-27 251 DRM_ERROR("Unable to init qxl irq\n");
2019-01-18 252 goto release_ring_free;
2018-07-27 253 }
2013-02-25 254
2013-02-25 255 /*
2013-02-25 256 * Note that virtual is surface0. We rely on the single ioremap done
2013-02-25 257 * before.
2013-02-25 258 */
2019-01-18 259 setup_slot(qdev, &qdev->main_slot, 0, "main",
2013-02-25 260 (unsigned long)qdev->vram_base,
2019-01-18 261 (unsigned long)qdev->rom->ram_header_offset);
2019-01-18 262 setup_slot(qdev, &qdev->surfaces_slot, 1, "surfaces",
2013-10-11 263 (unsigned long)qdev->surfaceram_base,
2013-10-11 264 (unsigned long)qdev->surfaceram_size);
2013-02-25 265
2013-02-25 266 INIT_WORK(&qdev->gc_work, qxl_gc_work);
2013-02-25 267
2013-02-25 268 return 0;
2018-07-27 269
2018-07-27 270 release_ring_free:
2018-07-27 271 qxl_ring_free(qdev->release_ring);
2018-07-27 272 cursor_ring_free:
2018-07-27 273 qxl_ring_free(qdev->cursor_ring);
2018-07-27 274 command_ring_free:
2018-07-27 275 qxl_ring_free(qdev->command_ring);
2018-07-27 276 ram_header_unmap:
2018-07-27 @277 iounmap(qdev->ram_header);
2018-07-27 278 bo_fini:
2018-07-27 279 qxl_bo_fini(qdev);
2018-07-27 280 rom_unmap:
2018-07-27 @281 iounmap(qdev->rom);
2018-07-27 282 surface_mapping_free:
2018-07-27 283 io_mapping_free(qdev->surface_mapping);
2018-07-27 284 vram_mapping_free:
2018-07-27 285 io_mapping_free(qdev->vram_mapping);
2018-07-27 286 return r;
2013-02-25 287 }
2013-02-25 288
line 277 was first introduced by commit
8efe929abd0d76e3792 drm: qxl: Fix error handling at qxl_device_init
<vasilyev@xxxxxxxxx>
<kraxel@xxxxxxxxxx>
Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: peterz: "Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control"
Previous message: Vinod Koul: "Re: [PATCH v3] usb: renesas-xhci: remove version check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]