Re: [PATCH v2 16/17] arm64: dts: imx8mp: Add media_blk_ctrl node

[Dong Aisheng]

On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa <abel.vesa@xxxxxxx> wrote:
>
> Some of the features of the media_ctrl will be used by some
> different drivers in a way those drivers will know best, so adding the
> syscon compatible we allow those to do just that. Only the resets
> and the clocks are registered bit the clk-blk-ctrl driver.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index dede0ae..2d6d213 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -736,6 +736,22 @@
>                         };
>                 };
>
> +               aips4: bus@32c00000 {
> +                       compatible = "simple-bus";
> +                       reg = <0x32c00000 0x400000>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges;
> +
> +                       media_blk_ctrl: clock-controller@32ec0000 {

For this combo device, maybe we can directly name it as blk-ctrl@32ec0000.
Rob, do you think if we can do that?

> +                               compatible = "fsl,imx8mp-media-blk-ctrl", "syscon";
> +                               reg = <0x32ec0000 0x10000>;
> +

Remove unnecessary blank line

Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx>

Regards
Aisheng

> +                               #clock-cells = <1>;
> +                               #reset-cells = <1>;
> +                       };
> +               };
> +
>                 aips5: bus@30c00000 {
>                         compatible = "fsl,aips-bus", "simple-bus";
>                         reg = <0x30c00000 0x400000>;
> --
> 2.7.4
>