Re: [PATCH] staging: emxx_udc: Use standard BIT() macro

[Randy Dunlap]

On 8/18/20 6:49 AM, Alex Dewar wrote:
> Currently emxx_udc.h defines bit values using local macros. Use the
> standard one instead.
> 
> Also, combine bit values with bitwise-or rather than addition, as
> suggested by Coccinelle.
> 
> Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx>

Hi,

Does this build?  Just checking.

Looks like it would need this:

#include <linux/bits.h>

since it (indirectly) provides definition of the BIT() macro.

> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++---------------
>  1 file changed, 211 insertions(+), 245 deletions(-)


thanks.
-- 
~Randy