Re: [PATCH] net: gianfar: Add of_node_put() before goto statement

[David Miller]

From: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>
Date: Wed, 19 Aug 2020 00:22:41 +0530

> Every iteration of for_each_available_child_of_node() decrements
> reference count of the previous node, however when control
> is transferred from the middle of the loop, as in the case of
> a return or break or goto, there is no decrement thus ultimately
> resulting in a memory leak.
> 
> Fix a potential memory leak in gianfar.c by inserting of_node_put()
> before the goto statement.
> 
> Issue found with Coccinelle.
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>

These OF iterators are so error prone...

Applied, thanks.