RE: [PATCHv2] PCI: designware-ep: Fix the Header Type check

[Z.q. Hou]

Hi Rob,

Thanks a lot for your review!

Regards,
Zhiqiang

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 2020年8月18日 21:52
> To: Z.q. Hou <zhiqiang.hou@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; PCI <linux-pci@xxxxxxxxxxxxxxx>; Lorenzo
> Pieralisi <lorenzo.pieralisi@xxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; Andrew Murray
> <amurray@xxxxxxxxxxxxxxxxxxxx>; Jingoo Han <jingoohan1@xxxxxxxxx>;
> Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
> Subject: Re: [PATCHv2] PCI: designware-ep: Fix the Header Type check
> 
> On Tue, Aug 18, 2020 at 3:35 AM Zhiqiang Hou <Zhiqiang.Hou@xxxxxxx>
> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> >
> > The current check will result in the multiple function device fails to
> > initialize. So fix the check by masking out the multiple function bit.
> >
> > Fixes: 0b24134f7888 ("PCI: dwc: Add validation that PCIe core is set
> > to correct mode")
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> > ---
> > V2:
> >  - Add marco PCI_HEADER_TYPE_MASK and print the masked value.
> >
> >  drivers/pci/controller/dwc/pcie-designware-ep.c | 3 ++-
> >  include/uapi/linux/pci_regs.h                   | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>