Re: [PATCH] mfd: core: Fix handle of OF disabled MFD cells

From: Lee Jones
Date: Wed Aug 19 2020 - 04:26:57 EST


On Wed, 19 Aug 2020, Icenowy Zheng wrote:

> 在 2020-08-19星期三的 09:11 +0100,Lee Jones写道:
> > On Sat, 01 Aug 2020, Icenowy Zheng wrote:
> >
> > > When rewriting the OF match code of MFD core, addition of cells
> > > disabled
> > > in OF will result in a failure with error -ENODEV. This is an
> > > unexpected
> > > behavior, as the previous behavior is silently ignore the cell. On
> > > SBCs with AXP20x PMICs, this leads to boot failure if AXP20x PMIC
> > > support is built-in and some cells (especially power supply ones)
> > > are
> > > disabled.
> >
> > Thanks for reporting this.
> >
> > Do you mind if I fix this another way? I plan to reinstate the old
> > code that was removed as part of the offending patch. I will of
> > course add your Reported-by tag.
>
> I think it's okay.
>
> I will test it once it's out.

That would be great. Then I can add your Tested-by also.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog