Re: [PATCH v7 0/2] pwm: intel: Add PWM driver for a new SoC

[Tanwar, Rahul]

Hi Andy,

On 19/8/2020 3:54 pm, Andy Shevchenko wrote:
> On Wed, Aug 19, 2020 at 7:18 AM Tanwar, Rahul
> <rahul.tanwar@xxxxxxxxxxxxxxx> wrote:
>>
>> Hi Andy,
>>
>> On 18/8/2020 4:38 pm, Andy Shevchenko wrote:
>>> On Tue, Aug 18, 2020 at 01:48:59PM +0800, Rahul Tanwar wrote:
>>>> Patch 1 adds dt binding document in YAML format.
>>>> Patch 2 add PWM fan controller driver for LGM SoC.
>>>>
>>>> v7:
>>>> - Address code quality related review concerns.
>>>> - Rename fan related property to pwm-*.
>>>> - Fix one make dt_binding_check reported error.
>>> I guess it misses the answer why pwm-fan can't be integrated into the soup?
>>>
>> Can you please elaborate more? I could not understand your point clearly.
> It's not mine, it's Uwe's. There is an hwmon module called pwm-fan. As
> far as *I* understand this, it can be utilized to control fans via PWM
> APIs. And Uwe asked you if you considered that and why you don't
> integrated  (coupled) it here.

Thanks for clarification. I now understand what Rob, Uwe & you mean by
pwm-fan. I will check in detail about it if we can integrate it with
pwm-fan hwmon driver.

Regards,
Rahul