Re: [PATCH] staging: wilc1000: Fix memory leak in wilc_bus_probe

From: Greg Kroah-Hartman
Date: Wed Aug 19 2020 - 10:55:58 EST


On Wed, Aug 19, 2020 at 04:47:59PM +0200, Markus Elfring wrote:
> > When devm_clk_get() returns -EPROBE_DEFER, spi_priv
> > should be freed just like when wilc_cfg80211_init() fails.
>
> How do you think about to choose an imperative wording for
> a corresponding change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
>
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot