Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

From: Jakub Kicinski
Date: Wed Aug 19 2020 - 12:25:57 EST


On Wed, 19 Aug 2020 17:18:15 +0200 Jiri Pirko wrote:
>>>> I will add counters on which reload were done. reload_down()/up() can return
>>>> which actions were actually done and devlink will show counters.
>>> Why a counter? Just return what was done over netlink reply.
>>
>> Such counters can be useful for debugging, telling which reload actions were
>> done on this dev from the point it was up.
>
> Not sure why this is any different from other commands...

Good question, perhaps because reset is more "dangerous"? The question
of "what reset this NIC" does come up in practice. With live activation
in the mix, knowing if the NIC FW was live activated will be very
useful for dissecting failures, I'd imagine.