Re: [PATCH] x86/mce: Increase maximum number of banks to 64

From: Borislav Petkov
Date: Thu Aug 20 2020 - 13:16:02 EST


On Thu, Aug 20, 2020 at 05:06:24PM +0000, Yazen Ghannam wrote:
> From: Akshay Gupta <Akshay.Gupta@xxxxxxx>
>
> ...because future AMD systems will support up to 64 MCA banks per CPU.
>
> MAX_NR_BANKS is used to allocate a number of data structures, and it is
> used as a ceiling for values read from MCG_CAP[Count]. Therefore, this
> change will have no functional effect on existing systems with 32 or
> fewer MCA banks per CPU.

Of course it will, grep for MAX_NR_BANKS and look at all those bitmaps
and arrays which get defined with MAX_NR_BANKS size. With your change,
they will double in size.

How much does vmlinux size grow with your change?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette