Re: [PATCH v4 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

[Chun-Kuang Hu]

Hi, Randy:

Randy Dunlap <rdunlap@xxxxxxxxxxxxx> 於 2020年8月19日 週三 下午11:58寫道：
>
> On 8/19/20 8:44 AM, Chun-Kuang Hu wrote:
> > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> > index aa74aac3cbcc..ca3cd871a350 100644
> > --- a/drivers/gpu/drm/mediatek/Kconfig
> > +++ b/drivers/gpu/drm/mediatek/Kconfig
> > @@ -24,6 +24,13 @@ config DRM_MEDIATEK_HDMI
> >       tristate "DRM HDMI Support for Mediatek SoCs"
> >       depends on DRM_MEDIATEK
> >       select SND_SOC_HDMI_CODEC if SND_SOC
> > -     select GENERIC_PHY
> > +     select PHY_MTK_HDMI
> >       help
> >         DRM/KMS HDMI driver for Mediatek SoCs
> > +
> > +config PHY_MTK_HDMI
> > +    tristate "MediaTek HDMI-PHY Driver"
> > +    depends on ARCH_MEDIATEK && OF
> > +    select GENERIC_PHY
> > +    help
> > +          Enable this to support HDMI-PHY
>
> Please fix all of these newly added lines.
>
> from Documentation/process/coding-style.rst:
>
> Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>

OK,

Regards,
Chun-Kuang.

>
> --
> ~Randy
>