Re: [PATCH v4 0/3] TypeC Connector Class driver improvements

From: Enric Balletbo i Serra
Date: Fri Aug 21 2020 - 03:13:23 EST


Hi Azhar,

I got a merge conflict because I applied [1] before these patches, fix the
conflict is trivial but, as I can't test, can you rebase your patches on top of
[1] and test and resend to make sure everything is working?

Thanks,
Enric

[1] https://lkml.org/lkml/2020/7/10/1063


On 21/8/20 1:38, Azhar Shaikh wrote:
> Changes in v4:
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
> usb_role_switch_set_role()"
> - Remove extra line between Fixes and Signed-off tag.
> - Added Reviewed-by and Cc tags from v1 and v2.
>
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice
> during disconnect"
> - Added Suggested-by from v2.
>
> * Patch 3: "platform/chrome: cros_ec_typec: Re-order connector
> configuration steps"
> - No change
>
> Changes in v3:
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
> usb_role_switch_set_role()"
> - No change
>
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice
> during disconnect"
> - Move the location of calling usb_role_switch_set_role() to
> end of function in cros_typec_configure_mux() to avoid any change
> in code flow.
>
> * Patch 3: "platform/chrome: cros_ec_typec: Re-order connector
> configuration steps"
> - New patch added
>
> Changes in v2:
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
> usb_role_switch_set_role()"
> - Update the commit message to change 'USB_ROLE_HOST in case of
> UFP.' to 'USB_ROLE_HOST in case of DFP.'
>
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice
> during disconnect"
> - New patch added.
>
> Azhar Shaikh (3):
> platform/chrome: cros_ec_typec: Send enum values to
> usb_role_switch_set_role()
> platform/chrome: cros_ec_typec: Avoid setting usb role twice during
> disconnect
> platform/chrome: cros_ec_typec: Re-order connector configuration steps
>
> drivers/platform/chrome/cros_ec_typec.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>