Re: [PATCH 2/2] x86/resctrl: Enable user to view thread or core throttling mode

[Borislav Petkov]

On Thu, Jul 16, 2020 at 10:53:14AM -0700, Fenghua Yu wrote:
>  struct rdt_membw {
> -	u32		max_delay;
> -	u32		min_bw;
> -	u32		bw_gran;
> -	u32		delay_linear;
> -	bool		mba_sc;
> -	u32		*mb_map;
> +	u32				max_delay;
> +	u32				min_bw;
> +	u32				bw_gran;
> +	u32				delay_linear;
> +	enum membw_throttle_mode	arch_throttle_mode;

I guess "arch" is implicit so you can

s/arch_throttle_mode/throttle_mode/g

...

> +static struct rftype *rdtgroup_rftype_by_name(const char *name)

That function name needs a verb.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette