Re: [PATCH v1] mfd: core: Fix double-free in mfd_remove_devices_fn()

From: Lee Jones
Date: Fri Aug 21 2020 - 10:47:06 EST


On Tue, 18 Aug 2020, Dmitry Osipenko wrote:

> The pdev.mfd_cell is released by platform_device_release(), which is
> invoked by platform_device_unregister(). Hence mfd_remove_devices_fn()
> shouldn't release the cell variable. The double-free bug is reported KASAN
> during of MFD driver module removal.
>
> Fixes: 466a62d7642f ("mfd: core: Make a best effort attempt to match devices with the correct of_nodes")
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> drivers/mfd/mfd-core.c | 2 --
> 1 file changed, 2 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog