Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state

[Rafael J. Wysocki]

On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote:
> Match the pattern elsewhere in this file.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> Tested-by: Marco Elver <elver@xxxxxxxxxx>

For all patches in the series:

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

> ---
>  drivers/cpuidle/cpuidle.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -153,7 +153,8 @@ static void enter_s2idle_proper(struct c
>  	 */
>  	stop_critical_timings();
>  	drv->states[index].enter_s2idle(dev, drv, index);
> -	WARN_ON(!irqs_disabled());
> +	if (WARN_ON_ONCE(!irqs_disabled()))
> +		local_irq_disable();
>  	/*
>  	 * timekeeping_resume() that will be called by tick_unfreeze() for the
>  	 * first CPU executing it calls functions containing RCU read-side
> 
> 
>