Re: [PATCH] net: dsa: b53: check for timeout

From: David Miller
Date: Fri Aug 21 2020 - 14:48:56 EST


From: trix@xxxxxxxxxx
Date: Fri, 21 Aug 2020 06:56:00 -0700

> From: Tom Rix <trix@xxxxxxxxxx>
>
> clang static analysis reports this problem
>
> b53_common.c:1583:13: warning: The left expression of the compound
> assignment is an uninitialized value. The computed value will
> also be garbage
> ent.port &= ~BIT(port);
> ~~~~~~~~ ^
>
> ent is set by a successful call to b53_arl_read(). Unsuccessful
> calls are caught by an switch statement handling specific returns.
> b32_arl_read() calls b53_arl_op_wait() which fails with the
> unhandled -ETIMEDOUT.
>
> So add -ETIMEDOUT to the switch statement. Because
> b53_arl_op_wait() already prints out a message, do not add another
> one.
>
> Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Applied and queued up for -stable, thanks.