Re: [RESEND] NTB: hw: amd: fix an issue about leak system resources

From: Jon Mason
Date: Mon Aug 24 2020 - 10:53:26 EST


On Tue, Aug 11, 2020 at 09:59:57AM +0800, Kaige Li wrote:
> The related system resources were not released when pci_set_dma_mask(),
> pci_set_consistent_dma_mask(), or pci_iomap() return error in the
> amd_ntb_init_pci() function. Add pci_release_regions() to fix it.
>
> Signed-off-by: Kaige Li <likaige@xxxxxxxxxxx>

Pulled into my ntb branch. I added:
Fixes: a1b3695820aa ("NTB: Add support for AMD PCI-Express Non-Transparent Bridge")

Thanks,
Jon

> ---
>
> changed commit massage.
>
> drivers/ntb/hw/amd/ntb_hw_amd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c
> index 88e1db6..71428d8 100644
> --- a/drivers/ntb/hw/amd/ntb_hw_amd.c
> +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c
> @@ -1203,6 +1203,7 @@ static int amd_ntb_init_pci(struct amd_ntb_dev *ndev,
>
> err_dma_mask:
> pci_clear_master(pdev);
> + pci_release_regions(pdev);
> err_pci_regions:
> pci_disable_device(pdev);
> err_pci_enable:
> --
> 2.1.0
>