drivers/gpu/drm/drm_bufs.c:343:36: sparse: sparse: incorrect type in argument 1 (different address spaces)

From: kernel test robot
Date: Mon Aug 24 2020 - 13:27:40 EST

tree: .config.gzDescription: application/gzip Sasha Levin: "[PATCH AUTOSEL 5.8 21/63] selftests/bpf: Fix segmentation fault in test_progs" Sasha Levin: "[PATCH AUTOSEL 5.8 24/63] libbpf: Prevent overriding errno when logging errors" date ] [ thread ] [ subject ] [ author ] /pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
sparse: use identifiers to define address spaces
as .config)
busercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> 2783aa
tree
make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arc
as appropriate
> sparse: incorrect type in assignment (different address spaces) @@ expected void *handle @@ got void [noderef] __iomem * @@
expected void *handle
got void [noderef] __iomem *
sparse: incorrect type in assignment (different address spaces) @@ expected void *handle @@ got void [noderef] __iomem * @@
expected void *handle
got void [noderef] __iomem *
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void *handle @@
expected void const [noderef] __iomem *addr
got void *handle
sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void *handle @@
expected void const [noderef] __iomem *addr
got void *handle
sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void *handle @@
expected void const [noderef] __iomem *addr
got void *handle
file (through include/linux/uaccess.h, include/linux/sched/task.h, include/linux/sched/signal.h, ...):
sparse: incorrect type in initializer (different address spaces) @@ expected unsigned char *d_char @@ got void [noderef] __user *to @@
expected unsigned char *d_char
got void [noderef] __user *to
sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void *handle @@
expected void const [noderef] __iomem *addr
got void *handle
undefined identifier '_PAGE_RW'
undefined identifier '_PAGE_RW'
sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void * @@
expected void const [noderef] __iomem *addr
got void *
incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void * @@
expected void const [noderef] __iomem *addr
got void *
sparse: sparse: invalid assignment: |=
left side has type unsigned int
right side has type restricted __le32
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] sgptr @@ got restricted __le32 [usertype] @@
expected unsigned int [usertype] sgptr
got restricted __le32 [usertype]
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] sgptr @@ got restricted __le32 [usertype] @@
expected unsigned int [usertype] sgptr
got restricted __le32 [usertype]
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] addr @@ got restricted __le32 [usertype] @@
expected unsigned int [usertype] addr
got restricted __le32 [usertype]
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] len @@ got restricted __le32 [usertype] @@
expected unsigned int [usertype] len
got restricted __le32 [usertype]
sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected void const [noderef] __iomem *addr @@ got unsigned char volatile [noderef] [usertype] __iomem *[usertype] maddr @@
expected void const [noderef] __iomem *addr
got unsigned char volatile [noderef] [usertype] __iomem *[usertype] maddr
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void [noderef] __user *__p @@ got unsigned int [usertype] * @@
expected void [noderef] __user *__p
got unsigned int [usertype] *
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
sparse: sparse: cast removes address space '__user' of expression
in included file (through include/linux/uaccess.h, include/linux/sched/task.h, include/linux/sched/signal.h, ...):
sparse: incorrect type in initializer (different address spaces) @@ expected unsigned char *d_char @@ got void [noderef] __user *to @@
expected unsigned char *d_char
got void [noderef] __user *to
sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got void * @@
sparse: expected void volatile [noderef] __iomem *addr
sparse: got void *
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got void * @@
sparse: expected void const volatile [noderef] __iomem *addr
sparse: got void *
/nv50.c:157:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void *[assigned] emap @@
/nv50.c:157:25: sparse: expected void const [noderef] __iomem *addr
sparse: got void *[assigned] emap
sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *map @@ got void [noderef] __iomem * @@
sparse: expected void *map
sparse: got void [noderef] __iomem *
sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void [noderef] __iomem * @@ got void *map @@
sparse: expected void [noderef] __iomem *
sparse: got void *map
sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void [noderef] __iomem * @@ got void *map @@
sparse: expected void [noderef] __iomem *
sparse: got void *map
sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __iomem *map @@ got void *map @@
sparse: expected void [noderef] __iomem *map
sparse: got void *map
/nv50.c:327:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem *addr @@ got void *[assigned] map @@
sparse: expected void const [noderef] __iomem *addr
sparse: got void *[assigned] map
cm/linux/kernel/git/torvalds/linux.git/commit/?id=670d0a4b10704667765f7d18f7592993d02783aa">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=670d0a4b10704667765f7d18f7592993d02783aa
it.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
r> 2005-06-23 136
2020-03-06 137 /*
Herrenschmidt 2009-02-02 138 * Core function to create a range of memory available for mapping by a
Herrenschmidt 2009-02-02 139 * non-root process.
2005-04-16 140 *
2005-04-16 141 * Adjusts the memory offset to its absolute value according to the mapping
2005-04-16 142 * type. Adds the map to the map list drm_device::maplist. Adds MTRR's where
2005-04-16 143 * applicable and if supported by the kernel.
2005-04-16 144 */
Herrenschmidt 2009-02-02 145 static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
2007-07-11 146 unsigned int size, enum drm_map_type type,
2007-07-11 147 enum drm_map_flags flags,
2007-07-11 148 struct drm_map_list **maplist)
2005-04-16 149 {
Herrenschmidt 2009-02-02 150 struct drm_local_map *map;
2007-07-11 151 struct drm_map_list *list;
2006-08-07 152 unsigned long user_token;
2006-08-07 153 int ret;
2005-04-16 154
2009-03-24 155 map = kmalloc(sizeof(*map), GFP_KERNEL);
2005-04-16 156 if (!map)
2005-04-16 157 return -ENOMEM;
2005-04-16 158
2005-07-10 159 map->offset = offset;
2005-07-10 160 map->size = size;
2005-07-10 161 map->flags = flags;
2005-07-10 162 map->type = type;
2005-04-16 163
2005-04-16 164 /* Only allow shared memory to be removable since we only keep enough
2005-04-16 165 * book keeping information about shared memory to allow for removal
2005-04-16 166 * when processes fork.
2005-04-16 167 */
2005-04-16 168 if ((map->flags & _DRM_REMOVABLE) && map->type != _DRM_SHM) {
2009-03-24 169 kfree(map);
2005-04-16 170 return -EINVAL;
2005-04-16 171 }
Herrenschmidt 2009-02-02 172 DRM_DEBUG("offset = 0x%08llx, size = 0x%08lx, type = %d\n",
Herrenschmidt 2009-02-02 173 (unsigned long long)map->offset, map->size, map->type);
Herrenschmidt 2009-05-18 174
Herrenschmidt 2009-05-18 175 /* page-align _DRM_SHM maps. They are allocated here so there is no security
Herrenschmidt 2009-05-18 176 * hole created by that and it works around various broken drivers that use
Herrenschmidt 2009-05-18 177 * a non-aligned quantity to map the SAREA. --BenH
Herrenschmidt 2009-05-18 178 */
Herrenschmidt 2009-05-18 179 if (map->type == _DRM_SHM)
Herrenschmidt 2009-05-18 180 map->size = PAGE_ALIGN(map->size);
Herrenschmidt 2009-05-18 181
Herrenschmidt 2009-02-02 182 if ((map->offset & (~(resource_size_t)PAGE_MASK)) || (map->size & (~PAGE_MASK))) {
2009-03-24 183 kfree(map);
2005-04-16 184 return -EINVAL;
2005-04-16 185 }
2005-04-16 186 map->mtrr = -1;
2005-04-16 187 map->handle = NULL;
2005-04-16 188
2005-04-16 189 switch (map->type) {
2005-04-16 190 case _DRM_REGISTERS:
2005-04-16 191 case _DRM_FRAME_BUFFER:
2010-05-27 192 #if !defined(__sparc__) && !defined(__alpha__) && !defined(__ia64__) && !defined(__powerpc64__) && !defined(__x86_64__) && !defined(__arm__)
2006-01-11 193 if (map->offset + (map->size-1) < map->offset ||
2005-04-16 194 map->offset < virt_to_phys(high_memory)) {
2009-03-24 195 kfree(map);
2005-04-16 196 return -EINVAL;
2005-04-16 197 }
2005-04-16 198 #endif
2005-07-10 199 /* Some drivers preinitialize some maps, without the X Server
2005-07-10 200 * needing to be aware of it. Therefore, we just return success
2005-07-10 201 * when the server tries to create a duplicate map.
2005-07-10 202 */
2005-09-05 203 list = drm_find_matching_map(dev, map);
2005-09-05 204 if (list != NULL) {
2005-09-05 205 if (list->map->size != map->size) {
2005-07-10 206 DRM_DEBUG("Matching maps of type %d with "
2005-07-10 207 "mismatched sizes, (%ld vs %ld)\n",
2005-09-25 208 map->type, map->size,
2005-09-25 209 list->map->size);
2005-09-05 210 list->map->size = map->size;
2005-07-10 211 }
2005-07-10 212
2009-03-24 213 kfree(map);
2005-09-05 214 *maplist = list;
2005-07-10 215 return 0;
2005-07-10 216 }
2005-07-10 217
2005-04-16 218 if (map->type == _DRM_FRAME_BUFFER ||
2005-04-16 219 (map->flags & _DRM_WRITE_COMBINING)) {
2013-05-13 220 map->mtrr =
2013-05-13 221 arch_phys_wc_add(map->offset, map->size);
2005-04-16 222 }
2007-08-25 223 if (map->type == _DRM_REGISTERS) {
2013-05-13 224 if (map->flags & _DRM_WRITE_COMBINING)
2013-05-13 @225 map->handle = ioremap_wc(map->offset,
2013-05-13 226 map->size);
2013-05-13 227 else
2007-01-08 228 map->handle = ioremap(map->offset, map->size);
2007-08-25 229 if (!map->handle) {
2009-03-24 230 kfree(map);
2007-08-25 231 return -ENOMEM;
2007-08-25 232 }
2007-08-25 233 }
2007-08-25 234
2005-04-16 235 break;
2005-04-16 236 case _DRM_SHM:
2007-02-10 237 list = drm_find_matching_map(dev, map);
2007-02-10 238 if (list != NULL) {
2007-02-10 239 if (list->map->size != map->size) {
2007-02-10 240 DRM_DEBUG("Matching maps of type %d with "
2007-02-10 241 "mismatched sizes, (%ld vs %ld)\n",
2007-02-10 242 map->type, map->size, list->map->size);
2007-02-10 243 list->map->size = map->size;
2007-02-10 244 }
2007-02-10 245
2009-03-24 246 kfree(map);
2007-02-10 247 *maplist = list;
2007-02-10 248 return 0;
2007-02-10 249 }
2007-01-08 250 map->handle = vmalloc_user(map->size);
2005-04-16 251 DRM_DEBUG("%lu %d %p\n",
2013-07-10 252 map->size, order_base_2(map->size), map->handle);
2005-04-16 253 if (!map->handle) {
2009-03-24 254 kfree(map);
2005-04-16 255 return -ENOMEM;
2005-04-16 256 }
2005-04-16 257 map->offset = (unsigned long)map->handle;
2005-04-16 258 if (map->flags & _DRM_CONTAINS_LOCK) {
2005-04-16 259 /* Prevent a 2nd X Server from creating a 2nd lock */
2016-06-21 260 if (dev->master->lock.hw_lock != NULL) {
2005-04-16 261 vfree(map->handle);
2009-03-24 262 kfree(map);
2005-04-16 263 return -EBUSY;
2005-04-16 264 }
2016-06-21 265 dev->sigdata.lock = dev->master->lock.hw_lock = map->handle; /* Pointer to lock */
2005-04-16 266 }
2005-04-16 267 break;
2007-02-10 268 case _DRM_AGP: {
2007-07-11 269 struct drm_agp_mem *entry;
2007-02-10 270 int valid = 0;
2007-02-10 271
2013-12-11 272 if (!dev->agp) {
2009-03-24 273 kfree(map);
2007-02-10 274 return -EINVAL;
2007-02-10 275 }
2005-04-16 276 #ifdef __alpha__
2005-04-16 277 map->offset += dev->hose->mem_space->start;
2005-04-16 278 #endif
2007-11-22 279 /* In some cases (i810 driver), user space may have already
2007-11-22 280 * added the AGP base itself, because dev->agp->base previously
2007-11-22 281 * only got set during AGP enable. So, only add the base
2007-11-22 282 * address if the map's offset isn't already within the
2007-11-22 283 * aperture.
2007-02-10 284 */
2007-11-22 285 if (map->offset < dev->agp->base ||
2007-11-22 286 map->offset > dev->agp->base +
2007-11-22 287 dev->agp->agp_info.aper_size * 1024 * 1024 - 1) {
2005-04-16 288 map->offset += dev->agp->base;
2007-11-22 289 }
2005-04-16 290 map->mtrr = dev->agp->agp_mtrr; /* for getmap */
2007-02-10 291
2007-02-10 292 /* This assumes the DRM is in total control of AGP space.
2007-02-10 293 * It's not always the case as AGP can be in the control
2007-02-10 294 * of user space (i.e. i810 driver). So this loop will get
2007-02-10 295 * skipped and we double check that dev->agp->memory is
2007-02-10 296 * actually set as well as being invalid before EPERM'ing
2007-02-10 297 */
2007-05-26 298 list_for_each_entry(entry, &dev->agp->memory, head) {
2007-02-10 299 if ((map->offset >= entry->bound) &&
2007-02-10 300 (map->offset + map->size <= entry->bound + entry->pages * PAGE_SIZE)) {
2007-02-10 301 valid = 1;
2007-02-10 302 break;
2007-02-10 303 }
2007-02-10 304 }
2007-05-26 305 if (!list_empty(&dev->agp->memory) && !valid) {
2009-03-24 306 kfree(map);
2007-02-10 307 return -EPERM;
2005-04-16 308 }
Herrenschmidt 2009-02-02 309 DRM_DEBUG("AGP offset = 0x%08llx, size = 0x%08lx\n",
Herrenschmidt 2009-02-02 310 (unsigned long long)map->offset, map->size);
2007-02-10 311
2008-11-05 312 break;
2009-09-17 313 }
2005-04-16 314 case _DRM_SCATTER_GATHER:
2005-04-16 315 if (!dev->sg) {
2009-03-24 316 kfree(map);
2005-04-16 317 return -EINVAL;
2005-04-16 318 }
2005-08-05 319 map->offset += (unsigned long)dev->sg->virtual;
2005-04-16 320 break;
2005-07-10 321 case _DRM_CONSISTENT:
2005-07-10 322 /* dma_addr_t is 64bit on i386 with CONFIG_HIGHMEM64G,
2005-07-10 323 * As we're limiting the address to 2^32-1 (or less),
2005-07-10 324 * casting it down to 32 bits is no problem, but we
2005-07-10 325 * need to point to a 64bit variable first. */
2020-02-02 326 map->handle = dma_alloc_coherent(&dev->pdev->dev,
2020-02-02 327 map->size,
2020-02-02 328 &map->offset,
2020-02-02 329 GFP_KERNEL);
2020-02-02 330 if (!map->handle) {
2009-03-24 331 kfree(map);
2005-07-10 332 return -ENOMEM;
2005-07-10 333 }
2005-07-10 334 break;
2005-04-16 335 default:
2009-03-24 336 kfree(map);
2005-04-16 337 return -EINVAL;
2005-04-16 338 }
2005-04-16 339
2010-08-11 340 list = kzalloc(sizeof(*list), GFP_KERNEL);
2005-04-16 341 if (!list) {
2006-10-25 342 if (map->type == _DRM_REGISTERS)
2007-01-08 @343 iounmap(map->handle);
2009-03-24 344 kfree(map);
2005-04-16 345 return -EINVAL;
2005-04-16 346 }
2005-04-16 347 list->map = map;
2005-04-16 348
2006-02-02 349 mutex_lock(&dev->struct_mutex);
2007-05-26 350 list_add(&list->head, &dev->maplist);
2006-08-07 351
2005-08-05 352 /* Assign a 32-bit handle */
2006-02-02 353 /* We do it here so that dev->struct_mutex protects the increment */
2006-08-07 354 user_token = (map->type == _DRM_SHM) ? (unsigned long)map->handle :
2006-08-07 355 map->offset;
2009-02-18 356 ret = drm_map_handle(dev, &list->hash, user_token, 0,
2009-02-18 357 (map->type == _DRM_SHM));
2006-08-07 358 if (ret) {
2006-10-25 359 if (map->type == _DRM_REGISTERS)
2007-01-08 360 iounmap(map->handle);
2009-03-24 361 kfree(map);
2009-03-24 362 kfree(list);
2006-08-07 363 mutex_unlock(&dev->struct_mutex);
2006-08-07 364 return ret;
2006-08-07 365 }
2006-08-07 366
2007-02-08 367 list->user_token = list->hash.key << PAGE_SHIFT;
2006-02-02 368 mutex_unlock(&dev->struct_mutex);
2005-04-16 369
2009-05-26 370 if (!(map->flags & _DRM_DRIVER))
2016-06-21 371 list->master = dev->master;
2005-09-05 372 *maplist = list;
2005-07-10 373 return 0;
2005-07-10 374 }
2005-09-05 375
by commit
drm: remove drm_ioremap and drm_ioremapfree
y/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
rong>

Next message: Sasha Levin: "[PATCH AUTOSEL 5.8 21/63] selftests/bpf: Fix segmentation fault in test_progs"
Previous message: Sasha Levin: "[PATCH AUTOSEL 5.8 24/63] libbpf: Prevent overriding errno when logging errors"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]