Re: [PATCH v7 09/10] arm64: efi: Export screen_info

[Greg KH]

On Mon, Aug 24, 2020 at 05:40:32PM +0000, Michael Kelley wrote:
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> Sent: Monday, August 24, 2020 10:35 AM
> > 
> > On Mon, Aug 24, 2020 at 09:46:22AM -0700, Michael Kelley wrote:
> > > The Hyper-V frame buffer driver may be built as a module, and
> > > it needs access to screen_info. So export screen_info.
> > >
> > > Signed-off-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> > > ---
> > >  arch/arm64/kernel/efi.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> > > index d0cf596..8ff557a 100644
> > > --- a/arch/arm64/kernel/efi.c
> > > +++ b/arch/arm64/kernel/efi.c
> > > @@ -55,6 +55,7 @@ static __init pteval_t
> > create_mapping_protection(efi_memory_desc_t *md)
> > >
> > >  /* we will fill this structure from the stub, so don't put it in .bss */
> > >  struct screen_info screen_info __section(.data);
> > > +EXPORT_SYMBOL(screen_info);
> > 
> > EXPORT_SYMBOL_GPL()?
> > 
> > I have to ask :)
> 
> It's also just EXPORT_SYMBOL(screen_info) in the x86, PowerPC, and Alpha
> architectures. I know that doesn't guarantee it's right, but I'll have to defer
> to the appropriate subsystem maintainers for whether it really should be
> EXPORT_SYMBOL_GPL.

Ok, fair enough, your original patch is fine.

thanks,

greg k-h