Re: [PATCH v2 2/2] leds: Add an optional property named 'sdb-gpios'

From: Rob Herring
Date: Mon Aug 24 2020 - 18:21:59 EST


On Sat, Aug 08, 2020 at 11:37:31AM +0800, Grant Feng wrote:
> The chip enters hardware shutdown when the SDB pin is pulled low.
> The chip releases hardware shutdown when the SDB pin is pulled high.
>
> Signed-off-by: Grant Feng <von81@xxxxxxx>
> ---
> Documentation/devicetree/bindings/leds/leds-is31fl319x.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt b/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
> index fc2603484544..e8bef4be57dc 100644
> --- a/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
> @@ -16,6 +16,7 @@ Optional properties:
> - audio-gain-db : audio gain selection for external analog modulation input.
> Valid values: 0 - 21, step by 3 (rounded down)
> Default: 0
> +- sdb-gpios : Specifier of the GPIO connected to SDB pin.

We normally use 'shutdown-gpios' for a shutdown GPIO.

>
> Each led is represented as a sub-node of the issi,is31fl319x device.
> There can be less leds subnodes than the chip can support but not more.
> @@ -44,6 +45,7 @@ fancy_leds: leds@65 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x65>;
> + sdb-gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>;
>
> red_aux: led@1 {
> label = "red:aux";
> --
> 2.17.1
>
>