Re: [PATCH] typhoon: switch from 'pci_' to 'dma_' API
From: David Miller
Date: Mon Aug 24 2020 - 20:33:42 EST
From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Sun, 23 Aug 2020 08:11:50 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> When memory is allocated in 'typhoon_init_one()' GFP_KERNEL can be used
> because it is a probe function and no lock is acquired.
>
> When memory is allocated in 'typhoon_download_firmware()', GFP_ATOMIC
> must be used because it can be called from a .ndo_tx_timeout function.
> So this function can be called with the 'netif_tx_lock' acquired.
> The call chain is:
> --> typhoon_tx_timeout (.ndo_tx_timeout function)
> --> typhoon_start_runtime
> --> typhoon_download_firmware
>
> While at is, update some comments accordingly.
...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Applied.